[cfe-dev] [LLVMdev] Commit message policy?

Jordan Rose jordan_rose at apple.com
Wed Sep 24 16:25:28 PDT 2014


> On Sep 24, 2014, at 16:19, Jonathan Roelofs <jonathan at codesourcery.com> wrote:
> 
> 
> 
> On 9/24/14 5:03 PM, Tim Northover wrote:
>> On 24 September 2014 15:51, Renato Golin <renato.golin at linaro.org> wrote:
>>> The idea, AFAIK, is to have a title with 50 chars, separated by an
>>> empty line and an infinite number of 80-col lines following.
>> 
>> I tend to follow something like that anyway so I think it's a good
>> idea, but if anything I'd prefer a longer title line than the body.
>> Particularly with the prefixes we tend to put in there, 50 chars is
>> hardly anything.
> I tend to look at this like I look at superExtremelyLongFunctionNames:
> if it needs a really long description for the summary, maybe it's better
> to break it into a few smaller patches. My $0.02, anyway... :)

Just as an example, the case I've run into is something like:

[analyzer] Separate RegionStore::getElementRegion and ...getFieldRegion

which, even with the abbreviation, is 72 characters long. I can fit it into 70 with an ampersand, but...

Jordan



More information about the cfe-dev mailing list