[cfe-dev] libc++ clean-up

[Sean Silva]

On Thu, Sep 4, 2014 at 5:36 AM, "C. Bergström" <cbergstrom at pathscale.com>
wrote:

>
> Hi
>
> Would patches for cleaning up unnecessary #include for libc++ be accepted?
> In general it seems like it has followed the rather poorly designed GNU STL
> rather than being more strict.
>
> A simple preprocessed hello world which only #include <iostream>
>
> CC -E hello.cxx -std=c++11  > hello-libcxx.e.cxx
>
> du -sh *.e.cxx
> 532K    hello-stdcxx.e.cxx
> 1.3M    hello-libcxx.e.cxx
>
> The effects of this cascade into being a measurable performance difference
> later on in the compiler. (My numbers may not be exactly llvm upstream
> though - ymmv) Basically the Module size and other things are larger as a
> result.
>
> Thoughts/feedback?
>

The code for the two libraries is different though. How did your
measurements correct for that, so that you can so surely attribute it to
unnecessary includes, and not simply differences in implementation?

-- Sean Silva


>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140904/9cb6ae40/attachment.html>