[cfe-dev] [PATCH] Refactoring: fix making absolute FilePath in Replacement

[Justin Bogner]

Justin Bogner <mail at justinbogner.com> writes:
> Steffen Prohaska <prohaska at zib.de> writes:
>> An std::error_code of 0 indicates success.  The condition must be reversed.
>>
>> See diff below for http://llvm.org/svn/llvm-project/cfe/trunk>
>> ---
>>
>> Hello,
>> I'm unsure whether this is the right way to submit a patch.  Please let me
>> know if I should prepare it in a different way.
>
> Generally, we prefer patches to be sent to cfe-commits@, rather than
> cfe-dev@, for future reference.
>
> Additionally, we usually like to check in a test with bug fixes. This is
> pretty obvious by inspection, but if you have a case where it fails and
> can easily be reduced, submitting that as well would be appreciated.

On further inspection, fixing this opens a whole can of worms. It looks
like we've been relying on it being broken for quite a while. I've sent
an alternative patch to cfe-commits for review:

    http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140901/113949.html