[cfe-dev] 2 trivial patches for libc++
Eric Fiselier
eric at efcs.ca
Wed Oct 29 15:58:46 PDT 2014
I've reached out to the author of the patch to get his permission. I'll
review and test the CMake patch tonight and then commit it.
/Eric
On Wed, Oct 29, 2014 at 12:27 PM, C Bergström <cbergstrom at pathscale.com>
wrote:
>
>
> On Thu, Oct 30, 2014 at 1:09 AM, Renato Golin <renato.golin at linaro.org>
> wrote:
>
>> On 29 October 2014 01:25, Chandler Carruth <chandlerc at google.com> wrote:
>> > I'd much rather have someone just post a patch they authored than think
>> > about the details of such things.... Much simpler....
>>
>> I agree. Doesn't cost anything, and makes things a lot clearer.
>>
>
> We're talking about moving a #if a couple lines down. I'd agree there's a
> line nobody wants to cross, but it's unrealistic to think this could be
> done another way. The time taken for 3 people to write emails was longer
> than the commit message.
>
> (Now I guess I understand why FreeBSD has local changes that aren't
> upstream..)
>
> UGH
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20141029/0b4eefcc/attachment.html>
More information about the cfe-dev
mailing list