[cfe-dev] libcxxrt+libc++ build regression

[Eric Fiselier]

> I'm curious why you're using find_library and why it worked fine before.

The change was made so that the ABI library did not need to be located on
the linkers search path.
find_library is used so that CMake properly links against the library.

> Abbreviated paths
> /somepath/bot/src/libcxx
> /somepath/bot/src/libcxxrt
>
> cmake is being ran from
> /somepath/bot/build/foobar - In our case we have a global cmake which
wraps everything

The important path is where libcxxrt.so is located. Could you provide that?

> I think we were explicitly setting the path before  (I need to double
check this) and if that variable is set - find_path shouldn't be used

Would you be able to clarify this? What path and what variable are you
setting? What about find_path?

/Eric


On Sat, Oct 18, 2014 at 1:20 AM, Chandler Carruth <chandlerc at google.com>
wrote:

>
> On Sat, Oct 18, 2014 at 12:10 AM, C Bergström <cbergstrom at pathscale.com>
> wrote:
>
>> I'm curious why you're using find_library and why it worked fine before.
>>
>
> It's the standard CMake way of doing things.
>
>
>>
>> Abbreviated paths
>> /somepath/bot/src/libcxx
>> /somepath/bot/src/libcxxrt
>>
>> cmake is being ran from
>> /somepath/bot/build/foobar - In our case we have a global cmake which
>> wraps everything
>>
>> I think we were explicitly setting the path before  (I need to double
>> check this) and if that variable is set - find_path shouldn't be used
>>
>
> This sounds very likely like your hard coded variables no longer match
> reality. You may have to update your build bot, but I don't really see how
> we can help with a custom CMake setup that others don't have and isn't
> represented by one of the public build bots? :: shrug ::
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20141018/c58cfcb8/attachment.html>