[cfe-dev] Allowing '_' as version tuple separator?

[jahanian]

On Oct 1, 2014, at 9:22 AM, Reid Kleckner <rnk at google.com> wrote:

> I see, you're proposing to change Parser::ParseVersionTuple() and maybe VersionTuple::tryParse(). Sounds fine to me.

Change went in Parser::ParseVecsionTuple() which is called as part of “availability” attribute parsing only. So, no impact on
any other versioning scheme.
In r218884. 
- Fariborz

> 
> On Tue, Sep 30, 2014 at 4:52 PM, jahanian <fjahanian at apple.com> wrote:
> Sure. Our primary interest is in their use in availability/deprecated attributes. 
> 
> An example would be:
> @protocol P
> - (void)proto_method __attribute__((availability(macosx,introduced=10_1_0,deprecated=10_2)));
> @end
> 
> Instead of:
> @protocol P
> - (void)proto_method __attribute__((availability(macosx,introduced=10.1.0,deprecated=10.2)));
> @end
> 
> But, 'major[.minor[.subminor]]’ are parsed and ‘.’ are checked for, irrespective of their use. 
> So, rather than special case for what we need, I am proposing to allow them everywhere.
> 
> - Fariborz
> 
> On Sep 30, 2014, at 4:45 PM, Reid Kleckner <rnk at google.com> wrote:
> 
>> Can you elaborate on what exactly you're planning to change? Just the output of -help, or do we parse LLVM's version somewhere?
>> 
>> On Tue, Sep 30, 2014 at 3:47 PM, jahanian <fjahanian at apple.com> wrote:
>> I would like to move on with this if there is no objections.
>> 
>> - Fariborz
>> 
>> On Sep 29, 2014, at 4:41 PM, jahanian <fjahanian at apple.com> wrote:
>> 
>>> 
>>>> Hi All,
>>>> We have internal request to allow ‘_’ in addition to ‘.’ as version tuple separators.
>>>> So, in addition to 'major[.minor[.subminor]]’, proposal is to allow ‘major[_minor[_subminor]]’
>>>> as well. Is there a reason we shouldn’t do this?
>>>> 
>>>> - Thanks, Fariborz
>>>> 
>>> 
>>> _______________________________________________
>>> cfe-dev mailing list
>>> cfe-dev at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> 
>> 
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> 
>> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20141002/0cce5593/attachment.html>