[cfe-dev] StringMap moves its Allocator. What happens with a reference?

[David Blaikie]

On Mon, Nov 17, 2014 at 1:13 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

> A common pattern is having one allocator serve several data structures,
>

Given that we don't have any uses or tests of this in tree (since it
doesn't work in StringMap and I assume it doesn't work in any of our other
ADTs either?) I suspect it's not quite as common as it may appear. I'm not
sure it's even valid for C++ standard allocators (which LLVM's allocators
are not implementations of), is it?


> for instance
>
>  typedef StringMap<bool, BumpPtrAllocator&> SymbolTable;
>  BumpPtrAllocator Allocator;
>  SymbolTable Sym1;
>  SymbolTable Sym2;
>  Sym2 = std::move(Sym1);
>
> With gcc 4.9.1 this fails
>
> /llvm/include/llvm/ADT/StringMap.h:
>   In instantiation of 'llvm::StringMap<ValueTy,
> AllocatorTy>::StringMap(llvm::StringMap<ValueTy, AllocatorTy>&&)
>   [with ValueTy = llvm::MCSymbol*; AllocatorTy =
> llvm::BumpPtrAllocatorImpl<>&]':
>
> /llvm/include/llvm/ADT/StringMap.h:243:74:
>   error: invalid initialization of non-const reference of type
> 'llvm::BumpPtrAllocatorImpl<>&'
>   from an rvalue of type
> 'std::remove_reference<llvm::BumpPtrAllocatorImpl<>&>::type {aka
> llvm::BumpPtrAllocatorImpl<>}'
>        : StringMapImpl(std::move(RHS)),
> Allocator(std::move(RHS.Allocator)) {}
>
> due to the inability to move the allocator reference where in fact we wish
> to copy it.
>
> With Visual C++ 2013 the code compiles and apperantly copies the allocator
> reference.
>
> What is the proper way to move such StringMaps or other data structures
> using an allocator reference?
>

I imagine the correct way to do this would be to write a wrapper/proxy
allocator (with a raw Allocator* inside it that can then be correctly
copied/moved/whatever). Though I could be wrong/haven't given this lots of
thought.

- David


>
> Yaron
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20141117/3af7b37a/attachment.html>