[cfe-dev] [PATCH] Clang Static Analyzer support for temporary destructors

[Jordan Rose]

On Mar 31, 2014, at 10:40, Alex McCarthy <alexmc at google.com> wrote:

> Thanks for your advice, Jordan.
> 
> I've split the NORETURN printing changes to CFG.cpp and the new test additions into a separate patch (attached). Hopefully this should be a safe no-op from a behavior perspective: debug output changes slightly, and the new test cases more accurately reflects current clang behavior. Does this look safe to commit?

Rather than commenting out tests, I'd prefer you put them in with the "wrong" expected-warnings, and then put a FIXME next to the warnings. Commented-out tests become dead tests all too easily.

I would drop the tests from nullptr.cpp. That file's for testing nullptr and nullptr_t specifically, not null pointers in general, and the new tests don't actually test any new behavior if we already believe that nullptr properly converts to a null pointer value.

Jordan