[cfe-dev] facebook clang plugins

[Anna Zaks]

We'd also prefer you to prepare separate patches for each checker. It would be a big plus if you added empirical data as well: how much testing has the checker been though, what is the false positives ratio, how effective is it (bugs found).

It looks like some of the checkers come from Facebook coding policies and might not be applicable for "a turned on by default checker". It would be good to note that as well.

Thanks!
Anna.

> On Jun 23, 2014, at 1:52 PM, Mathieu Baudet <mathieubaudet at fb.com> wrote:
> 
> Thanks Anna. Indeed, it looks like the checker IdenticalExprChecker.cpp is strictly more general than the one in the plugin (since https://llvm.org/svn/llvm-project/cfe/trunk@201702).
> I will remove the duplicate.

You could double check if the existing checker is on by default.

> 
>> Mathieu,
>> 
>> One of the analyzer checkers looks similar/like a subset of this one:
>>  cfe/trunk/lib/StaticAnalyzer/Checkers/IdenticalExprChecker.cpp
>>  cfe/trunk/test/Analysis/identical-expressions.cpp
>> 
>> Cheers,
>> Anna.
>