[cfe-dev] [LLVMdev] Bug in MapVector::erase ?

David Blaikie dblaikie at gmail.com
Tue Jul 15 13:51:06 PDT 2014


On Tue, Jul 15, 2014 at 1:42 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>
>> On 2014-Jul-15, at 11:28, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>>
>>
>>> On 2014-Jul-15, at 11:07, Reid Kleckner <rnk at google.com> wrote:
>>>
>>> Can we explicitly delete the erase method or do something else to document the fact that it is unsupported?  It was added incidentally in r211350, even though it was added and removed by Doug back in r175538 / r175449.
>>>
>>
>> I'm happy with it deleted or fixed (see WIP patch that fixes it w/o
>> tests).  For now, I'll fix it, and then David (or someone else) can
>> migrate the code to `remove_if()`.
>>
>> FWIW, when it's fixed, it doesn't have to be "unsupported" -- it's
>> just *slow*.
>
> Committed a whitespace change in r213082, fixed `erase()` in r213084, and added `remove_if()` in r213090.
>
> I'll leave it up to David how to move forward once the MCDwarf stuff
> migrates to `remove_if()`.
>
> If re-deleting `erase()` is the plan, someone should update the comments
> and the docs right away to say so (I changed the text to document its
> complexity, rather than lack of support).

Doubt I'll get to making any changes immediately (including switching
over to remove_if - perhaps Oscar can send a CR for that) but will
keep it all in mind :)

Thanks again!

- Dave



More information about the cfe-dev mailing list