[cfe-dev] libcxxabi cmake test problem on Linux x86-64

[Dan Albert]

Submitted (with some slight modifications, s/libgcc_s/libgcc_eh/) as
r212958. Tested with and without the LLVM unwinder, and things look good.
Thanks again!

On Sun Jul 13 2014 at 2:00:40 AM, İsmail Dönmez <ismail at donmez.ws> wrote:

> Hi,
>
> How about the attached patch?
>
>
> On Sat, Jul 12, 2014 at 11:59 PM, Dan Albert <danalbert at google.com> wrote:
>
>> Ah. Okay, that makes sense. Odd that I don't see it though.
>>
>> -lpthread is fine to include unconditionally, but -lgcc_s should be
>> linked based on LIBCXXABI_USE_LLVM_UNWINDER (if true, link libunwind, else
>> link libgcc_s). libgcc is unfortunately far reaching, in that it has all of
>> the compiler replacement functions *and* the unwinder, so that may not
>> be quite correct. We may need to do -lunwind -lcompiler-rt in the case of
>> LIBCXXABI_USE_LLVM_UNWINDER=ON, else -lgcc_s.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140714/e910c2d2/attachment.html>