[cfe-dev] [libcxx] test/lit.cfg patch

[Marshall Clow]

On Jan 28, 2014, at 3:56 PM, David Fang <fang at csl.cornell.edu> wrote:

> Hi,
> 
> Here's another revision of the patch that doesn't call lit.util.which when cxx_under_test is already !None.  In either case, lit_config.note() still reports the value of cxx_under_test, makes sure user is running the intended clang++ binary.
> 
> LGTY?

LGTM.

— Marshall

> 
> David
> 
>> Hi,
>> 	I discovered that when testing libc++ with cmake/lit (make check-libcxx), it was choosing an installed clang++ from my $PATH over the value passed in ${builddir}/test/lit.site.cfg (which is an uninstalled clang++). The attached patch fixes this, and seems to match the comment in context. Ok to commit?
>> 
>> David
>> 
>> 
> 
> -- 
> David Fang
> http://www.csl.cornell.edu/~fang/
> <cxx_under_test.patch>_______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev