[cfe-dev] clang-format and namespaces

Daniel Jasper djasper at google.com
Sun Jan 26 21:40:03 PST 2014


There was no intentional change in behavior here, but depending on the
input, clang-format might always have done this or we might have introduced
a bug. Can you give me instructions to reproduce the behavior? What exactly
was your input to clang-format-diff?
On Jan 27, 2014 4:27 AM, "Alp Toker" <alp at nuanti.com> wrote:

>  Hi Daniel,
>
> clang-format-diff is clobbering the existing indentation of namespaces in
> the LLVM codebase:
>
> --- a/include/llvm/Support/ErrorHandling.h
> +++ b/include/llvm/Support/ErrorHandling.h
> @@ -19,7 +19,7 @@
>  #include <string>
>
>  namespace llvm {
> -  class StringRef;
> +class StringRef;
>    class Twine;
>
> CCing the list as it's easy to miss before committing for anyone else
> using the tool, so heads up on that.
>
> (Switching back to a clang-format snapshot from a couple of months ago has
> worked out fine to format the large-scale refactoring changes landed to ToT
> last week.)
>
> Alp.
>
>
> -- http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140127/f28d812b/attachment.html>


More information about the cfe-dev mailing list