[cfe-dev] r131701 and test/CodeGenObjC/debug-property-synth.m

[Adrian Prantl]

Hi David,

I committed the improved version of the test in r201248.

-- adrian

On Feb 12, 2014, at 10:26, Adrian Prantl <aprantl at apple.com> wrote:

> 
> On Feb 11, 2014, at 21:12, David Blaikie <dblaikie at gmail.com> wrote:
> 
>> > So my best guess is that this test became useless at some point (possibly at 139468) due to refactoring and that the issue is currently covered by debuginfo-properties.m.
>> 
>> AFAICT debuginfo-properties.m checks for the DW_AT_decl_line in the debug info, whereas this tests for a line table entry. I forgot to mention that the radar was about being able to set a breakpoint on the property.
>> 
>> OK - though I wasn't able to get the test case to fail. I suspect because something else ended up with the same line information, perhaps? Or it ended up with the correct line info through some other means? (I didn't diff the full output to see if it changed)
>> 
>> The commit the test case was addressing didn't seem like it was doing anything line-table specific... I assume it was just testing the line table because it was a convenient way to test the line associated with this construct (I assume this was originally a grep test long before llvm-dwarfdump for example).
> 
> I'm rewriting the debug-property-synth.m test to be IR-based (and documented!) now — based on the description in the radar.
> Passing the StartLoc all the way through affects both the line table location _and_ the DW_AT_decl_line of the function (which is read from the CGDebugInfo::CurLoc).
> 
>   void CodeGenFunction::StartFunction(...
>   ...
>       DI->setLocation(StartLoc);
>       DI->EmitFunctionStart(GD, FnType, CurFn, Builder);
>     }
> 
> -- adrian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140212/6112cf42/attachment.html>