[cfe-dev] Clang for windows

[Reid Kleckner]

I went ahead and added these in r216270.


On Fri, Aug 22, 2014 at 9:37 AM, Hans Wennborg <hans at chromium.org> wrote:

> On Thu, Aug 21, 2014 at 2:38 PM, Smith, Kevin B <kevin.b.smith at intel.com>
> wrote:
> > I was playing around with CLANG for windows (clang-cl.exe) and noticed
> that this doesn't support
> > _int64, but that it does support __int64.  For Microsoft compiler both
> __int64 and _int64 are recognized
> > as a keyword and basic type.
>
> [...]
>
> > $ svn diff
> > Index: include/clang/Basic/TokenKinds.def
> > ===================================================================
> > --- include/clang/Basic/TokenKinds.def  (revision 216129)
> > +++ include/clang/Basic/TokenKinds.def  (working copy)
> > @@ -558,6 +558,7 @@
> >  ALIAS("_uuidof"          , __uuidof   , KEYMS | KEYBORLAND)
> >  ALIAS("_inline"          , inline     , KEYMS)
> >  ALIAS("_declspec"        , __declspec , KEYMS)
> > +ALIAS("_int64"           , __int64    , KEYMS)
> >
> >  // Borland Extensions which should be disabled in strict conformance
> mode.
> >  ALIAS("_pascal"      , __pascal   , KEYBORLAND)
>
> Thank you for the patch! Yes, this looks like the right approach. We
> should do the same for _int8, _int16 and _int32. Like Richard pointed
> out, this needs a test (test/Lexer/ms-extensions.c is probably a good
> place). Would you like to add this to your patch, and then we can
> commit it for you?
>
> (David pointed out that the single-underscore variants of these types
> aren't available in MSVC with /Za, so maybe one day we should consider
> not exposing them with -fms-extensions by default.)
>
> Thanks,
> Hans
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140822/9f2ef7bc/attachment.html>