[cfe-dev] [PATCH 3/3] Fix virtual class with non-virtual dtor complaint

[Jonathan Roelofs]

LGTM

On 4/16/14, 9:33 AM, Dan Albert wrote:
> Fixes compiler complaint about:
> src/Unwind/UnwindCursor.hpp:366:25: error: 'libunwind::AbstractUnwindCursor' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
> ---
>   src/Unwind/UnwindCursor.hpp | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/Unwind/UnwindCursor.hpp b/src/Unwind/UnwindCursor.hpp
> index aa14dd1..035e471 100644
> --- a/src/Unwind/UnwindCursor.hpp
> +++ b/src/Unwind/UnwindCursor.hpp
> @@ -365,6 +365,7 @@ private:
>
>   class _LIBUNWIND_HIDDEN AbstractUnwindCursor {
>   public:
> +  virtual             ~AbstractUnwindCursor() {}
>     virtual bool        validReg(int) = 0;
>     virtual unw_word_t  getReg(int) = 0;
>     virtual void        setReg(int, unw_word_t) = 0;
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded