[cfe-dev] Slightly improved clang-format vim integration

[Tobias Grosser]

On 09/16/2013 07:14 PM, Steffen Prohaska wrote:
>
> On Sep 16, 2013, at 6:04 PM, Tobias Grosser <tobias at grosser.es> wrote:
>
>> Steffen, I believe the idea of your patch is great. Unfortunately it has from my point two issues:
>>
>> 1) You rely on features of very recent vim versions
>
> I've addressed this in in the revised script that I've just sent in a separate mail.

Great. Thanks for fixing this so quickly.

>> As this is not a complicated plugin, there seems no reason to drop support for older vim versions.
>>
>> 2) You require python in the .vimrc file
>>
>> I would prefer to not require python in the .vimrc, but have the plugin report an error when it is called without python support.
>
> Python has also been required by the previous version of the script.  So my proposed changes don't make the situation worse.

In case python is not supported, the previous script only failed when 
pressing the formatting key combination. The new script will fail as 
soon as vim is opened and the configuration is parsed. I believe this is 
a regression for people who would like to use the same .vimrc file 
across different systems.

I am personally not one of those people, so if others agree this is not 
important, I will rely on their judgement. On the other side, I don't 
feel comfortable OKing or commiting the patch myself.

In any case, thanks for working on this.

Cheers,
Tobias