[cfe-dev] deque<Incomplete Type> support

Zhihao Yuan zy at miator.net
Tue Nov 12 18:16:23 PST 2013


On Tue, Nov 12, 2013 at 6:26 PM, Dimitry Andric <dimitry at andric.com> wrote:
> Now there might
> be a problem when somebody else expects something different. :-)

So we only fix the cases without this possibility :)

>>  http://llvm.org/bugs/show_bug.cgi?id=9351
>
> Well, if this can be fixed in a similar way, and Howard thinks it is
> worthwhile, I don't see why not.  But personally I would still refrain
> from relying on it...

If more people rely on it, it's gonna be a good reason to
standardize it :)

Here is my proposed change: remove the _BlockSize template
parameter from __deque_iterator.  This does not decrease the
identify of __deque_iterator since it's templated on _ValueType
which covers the_BlockSize difference already.

Patch is attached.  Tests (+ a new one) passed.

-- 
Zhihao Yuan, ID lichray
The best way to predict the future is to invent it.
___________________________________________________
4BSD -- http://4bsd.biz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deque_rec.patch
Type: text/x-patch
Size: 59869 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20131112/ba73357d/attachment.bin>


More information about the cfe-dev mailing list