[cfe-dev] [LLVMdev] Handling SRet on Windows x86

Eric Christopher echristo at gmail.com
Thu Mar 28 13:49:41 PDT 2013

On Thu, Mar 28, 2013 at 1:46 PM, Anton Korobeynikov <asl at math.spbu.ru> wrote:
>> Sounds fine to me. I just wanted some convenient and consistent naming.
>> I think it conflicts a bit with the triples (-win32 currently means
>> msvc I think),
> Right. But this is again a historical (and LLVM-specific) artifact,
> because I doubt anyone uses such triplet outside to mean msvc
> compatibility.

Fair enough. Mostly most of the triples that exist aren't very useful for strict
msvc compatibility since it wasn't a mode that gcc embraced :)

>> but that'll probably be ok ultimately - internal function names are easy to
>> refactor if we decide to change the naming later.
> +1, but they should not confuse someone who reads / reviews the code :)

Yup, it was confusing in the first place which is why I'm commenting here :)


More information about the cfe-dev mailing list