[cfe-dev] Mode attribute not in clang AST.

Enea Zaffanella zaffanella at cs.unipr.it
Thu Jun 20 05:53:10 PDT 2013


On 06/19/2013 10:33 PM, Eli Friedman wrote:
> On Mon, Jun 10, 2013 at 11:55 PM, Enea Zaffanella
> <zaffanella at cs.unipr.it <mailto:zaffanella at cs.unipr.it>> wrote:
>
>     Ping.
>
>     Attached a slightly reviewed patch (only changes are in test cases,
>     where c++11 syntax has been moved into more appropriate place and
>     suitably quoted when checking it).
>
>     OK to commit?
>
>
> For your question about the getUnqualifiedObjCPointerType, I don't think
> so.  It's probably worth adding a test case for pretty-printing "id x;
> __strong id y;" in -fobjc-arc mode; we should print the __strong
> qualifier for the second one, but not the first.
>
> Otherwise, looks fine.
>
>   -Eli


Committed in r184417
(with additional ObjC pretty print test as suggested).

Thanks for reviewing,
Enea.




More information about the cfe-dev mailing list