[cfe-dev] local/unnamed enums as diagnostic parameters

[Evgeniy Stepanov]

Hi,

we've got a bunch of warnings on bootstrap bots since a few days ago
related to the use of local or anonymous enums in Sema::Diag(). This
results in template operator<< of SemaDiagnosticBuilder being
instantiated with an unnamed type, which, AFAIK, is invalid. Seems
like the right fix is cast such values to (int),

http://lab.llvm.org:8011/builders/clang-x86_64-debian-selfhost-rel/builds/4751/steps/compile.llvm.stage2/logs/warnings%20%2810%29

What really concerns me is the fact that self-hosted build of clang
has not been warning-free for several days, and no one seems to care.
And the bots do not enforce it. If this is still a goal (and I believe
it should be) then I suggest turning on -Werror on one or all
self-hosted bots and paying attention to regressions.