[cfe-dev] [compiler-rt] 2 nit Win32 patches

"C. Bergström" cbergstrom at pathscale.com
Wed Jul 17 07:13:19 PDT 2013


On 07/17/13 08:34 PM, Aaron Ballman wrote:
>
>>> I think a more clean approach would be to define a macro for the
>>> __attribute__'s being #ifdef'ed out, and then use the macros.  This is
>>> the approach taken elsewhere in llvm (see Compiler.h).
I may have missed this or misunderstood, but moving the "fix" outside of 
compiler-rt and depending on llvm/support is unwelcome. Currently 
compiler-rt builds fine standalone if you use the old old cmake files or 
maintain your own. /* Apologies if I misunderstood what you meant */



More information about the cfe-dev mailing list