[cfe-dev] RFC: Fix 'make' build in clang/tools/extra

[Vane, Edwin]

That said, I'm not really sure why this additional library is required. The tools in clang-tools-extra built and ran fine before. I also notice that the CMakeLists.txt don't link against asmparser, bitreader, or mc. Can anybody explain why these libs are necessary?

-----Original Message-----
From: Vane, Edwin 
Sent: Wednesday, January 23, 2013 9:20 AM
To: '??????? ????????'; cfe-dev at cs.uiuc.edu
Subject: RE: [cfe-dev] RFC: Fix 'make' build in clang/tools/extra

When did you last update? Chris Lattner committed this exact fix to clang-tools-extra Jan 19.

-----Original Message-----
From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu] On Behalf Of ??????? ????????
Sent: Wednesday, January 23, 2013 6:08 AM
To: cfe-dev at cs.uiuc.edu
Subject: [cfe-dev] RFC: Fix 'make' build in clang/tools/extra

Hi!

Some days ago build in clang/tools/extra start fail

if i understand correctly 3 Makefiles must be adopted to use bitreader

the following fix problem for me Fedora 17/x64, latest trunk

Thanks,
Dmitry

$ pwd
/home/dimhen/src/llvm/tools/clang/tools/extra
$ svn diff -x-p
Index: loop-convert/Makefile
===================================================================
--- loop-convert/Makefile    (revision 164013)
+++ loop-convert/Makefile    (working copy)
@@ -16,7 +16,7 @@ NO_INSTALL = 1
 TOOL_NO_EXPORTS = 1

 include $(CLANG_LEVEL)/../../Makefile.config
-LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser bitreader support mc
 USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a clangDriver.a \
            clangRewriteFrontend.a clangRewriteCore.a clangParse.a \
            clangSema.a clangAnalysis.a \
Index: remove-cstr-calls/Makefile
===================================================================
--- remove-cstr-calls/Makefile    (revision 164013)
+++ remove-cstr-calls/Makefile    (working copy)
@@ -16,7 +16,7 @@ NO_INSTALL = 1
 TOOL_NO_EXPORTS = 1

 include $(CLANG_LEVEL)/../../Makefile.config
-LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser bitreader support mc
 USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a clangDriver.a \
                      clangRewriteFrontend.a clangRewriteCore.a \
                      clangParse.a clangSema.a clangAnalysis.a \
Index: tool-template/Makefile
===================================================================
--- tool-template/Makefile    (revision 164013)
+++ tool-template/Makefile    (working copy)
@@ -16,7 +16,7 @@ NO_INSTALL = 1
 TOOL_NO_EXPORTS = 1

 include $(CLANG_LEVEL)/../../Makefile.config
-LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser bitreader support mc
 USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a clangDriver.a \
                      clangRewriteFrontend.a clangRewriteCore.a \
                      clangParse.a clangSema.a clangAnalysis.a \ _______________________________________________
cfe-dev mailing list
cfe-dev at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev