[cfe-dev] LLVM windows buildbots: Local patch "llvmclang.diff" being applied

[Siraj, Tareq A]

Looking at the name of the builder, it shouldn't be using mingw/msys. There seems to be other builders in the buildbot that uses mingw/msys. That being said, I am not entirely sure that this patch is the problem, but the content of this patch seems to be unknown which is concerning to me. It is possible that the test is passing on the build bot for some other reason, I just want to rule out the unknown patch from this problem :).

In a general workflow, I think a user should expect to see same results between the dev machines and the buildbots for certain documented configurations. This is the broken build I was talking about:

http://bb.pgr.jp/builders/cmake-clang-x64-msc16-R/builds/2105

Thanks.

--
Tareq A. Siraj
  Software Developer
  Intel of Canada, Inc.

From: Reid Kleckner [mailto:rnk at google.com]
Sent: Tuesday, August 06, 2013 11:50 AM
To: Siraj, Tareq A
Cc: Rafael Espíndola; cfe-dev at cs.uiuc.edu
Subject: Re: [cfe-dev] LLVM windows buildbots: Local patch "llvmclang.diff" being applied

Are you sure this wasn't just a mingw and msys vs cmd and MSVC issue?  It seems unlikely that this patch is the source of the discrepancy.

On Tue, Aug 6, 2013 at 7:42 AM, Siraj, Tareq A <tareq.a.siraj at intel.com<mailto:tareq.a.siraj at intel.com>> wrote:
Ping again :).

I am concerned about this local patch which seems to pass a test that is supposed to fail on windows (I tried it on 3 different machines). clang-tools-extra: r187428 was reverted because this test was marked XFAIL on windows but was passing on the buildbots. There are at least two bugs behind this which I am trying to fix currently but this change of behavior between dev builds and buildbots is a bit concerning. We should just incorporate the changes into trunk or at least document this on llvm.org<http://llvm.org>. Thanks.

--
Tareq A. Siraj
  Software Developer
  Intel of Canada, Inc.
-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com<mailto:rafael.espindola at gmail.com>]
Sent: Thursday, August 01, 2013 12:17 PM
To: Siraj, Tareq A
Cc: cfe-dev at cs.uiuc.edu<mailto:cfe-dev at cs.uiuc.edu>; Takumi NAKAMURA
Subject: Re: [cfe-dev] LLVM windows buildbots: Local patch "llvmclang.diff" being applied

ccing Takumi.

On 1 August 2013 12:07, Siraj, Tareq A <tareq.a.siraj at intel.com<mailto:tareq.a.siraj at intel.com>> wrote:
> Ping.
>
>
>
> --
>
> Tareq A. Siraj
>
>   Software Developer
>
>   Intel of Canada, Inc.
>
>
>
> From: cfe-dev-bounces at cs.uiuc.edu<mailto:cfe-dev-bounces at cs.uiuc.edu> [mailto:cfe-dev-bounces at cs.uiuc.edu<mailto:cfe-dev-bounces at cs.uiuc.edu>]
> On Behalf Of Siraj, Tareq A
> Sent: Wednesday, July 31, 2013 11:16 AM
> To: cfe-dev at cs.uiuc.edu<mailto:cfe-dev at cs.uiuc.edu>
> Subject: [cfe-dev] LLVM windows buildbots: Local patch "llvmclang.diff"
> being applied
>
>
>
> Does anyone know what the "llvmclang.diff" patch does to
> "llvm/utils/lit/lit/TestRunner.py" on the windows buildbots? It looks
> like it's a local patch to the buildbots and not part of the LLVM
> codebase. I tried emailing the maintainer of the buildbot but didn't get any reply.
> Thanks.
>
>
>
> http://bb.pgr.jp/builders/cmake-clang-x64-msc16-R/builds/2120/steps/sh
> ell_1
>
>
>
> --
>
> Tareq A. Siraj
>
>   Software Developer
>
>   SSG/DPD/ECDL/DMP
>
>   Phone: +1 519 772 2577
>
>
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu<mailto:cfe-dev at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>

_______________________________________________
cfe-dev mailing list
cfe-dev at cs.uiuc.edu<mailto:cfe-dev at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130806/620d6c6b/attachment.html>