[cfe-dev] ASTMatchers: isVirtual and isOverride

[Manuel Klimek]

On Sat, Apr 27, 2013 at 6:36 PM, Gábor Kozár <kozargabor at gmail.com> wrote:

>
> 2013/4/27 Manuel Klimek <klimek at google.com>
>
>> Just use the empty string for binding and getNodeAs :)
>
>
> That would potentially lead to confusion when there are more nodes bound,
> but the programmer forgot to supply the proper name. In my suggestion, the
> parameterless getNodeAs would have an assert to check there is exactly one
> node bound (and whose name is the default name).
>

If you put everything behind constants, I think it'll be easy enough to see
what's happening - and that's a generally good strategy anyway, as you get
a compile error if you mistype...
Thus, I think it'd not add enough value to special case the interface.


>
>
>
> 2013/4/27 Manuel Klimek <klimek at google.com>
>
>> On Sat, Apr 27, 2013 at 6:28 PM, Gábor Kozár <kozargabor at gmail.com>wrote:
>>
>>> Hi,
>>>
>>> 2013/4/26 Pedro Delgado Perez <pedro.delgadoperez at mail.uca.es>
>>>
>>>> Hehehe... I found the problem with this. I was binding wrongly the
>>>> matcher! I used a id in the matcher thas was different from the id in the
>>>> function that retrieves the nodes... I think this will be a typical mistake
>>>> for newbies...
>>>
>>>
>>> Ah, yes, that happens a lot to me as well. Now that I think about it, it
>>> might be worthwhile adding a parameterless .bind() and .getNodeAs<T>() for
>>> situations where only one node is bound. Should be fairly trivial, but also
>>> not all that useful...
>>>
>>
>> Just use the empty string for binding and getNodeAs :)
>>
>>
>>>
>>> 2013/4/26 Pedro Delgado Perez <pedro.delgadoperez at mail.uca.es>
>>>
>>>> Thanks both! Now I can see all this much clearer and I have the enough
>>>> knowledge to start out with clang.
>>>
>>>
>>> You're welcome. Good luck!
>>>
>>> 2013/4/25 Manuel Klimek <klimek at google.com>
>>>
>>>> And btw thanks a lot for all the great user support you're giving here!
>>>
>>>
>>> Thank you, I'm happy to help. Clang is a great project!
>>>
>>> As soon as the university term is over, I'm also planning on trying to
>>> contribute code-wise, mainly to the Static Analyzer but I guess also on
>>> just about anything that catches my attention. :) I'm quite excited - this
>>> is going to be the first open source project I contribute to.
>>>
>>> Gabor
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130427/14458587/attachment.html>