[cfe-dev] Phabricator feedback (was: [cfe-commits] [PATCH] Implement has()

[Daniel Jasper]

I just didn't write a description, as I think the title concisely
describes what the patch does. I created the review on the website,
not with arcanist.

On Fri, Oct 26, 2012 at 6:42 PM, Manuel Klimek <klimek at google.com> wrote:
> On Fri, Oct 26, 2012 at 6:38 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Fri, Oct 26, 2012 at 8:34 AM, Manuel Klimek <klimek at google.com> wrote:
>> > On Fri, Oct 26, 2012 at 5:02 PM, David Blaikie <dblaikie at gmail.com>
>> > wrote:
>> >>
>> >>  and hasDescendant() for QualTypes and TypesLocs.)
>> >> MIME-Version: 1.0
>> >> Content-Type: multipart/mixed;
>> >> boundary="b1_04036864fe6f78f09472efdaebba17b2"
>> >>
>> >> --b1_04036864fe6f78f09472efdaebba17b2
>> >> Content-Type: text/plain; charset="utf-8"
>> >> Content-Transfer-Encoding: 7bit
>> >>
>> >> Manuel, could we get the patch/review description these emails?
>> >
>> >
>> >
>> > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121022/066885.html
>> >
>> > What's the problem?
>>
>> I just assumed there was actually a patch description somewhere - but
>> looking at the code review on the website I see there's nothing more
>> than the patch and a one sentence title.
>>
>> I see in other reviews ( http://llvm-reviews.chandlerc.com/D56 ) that
>> the summary is included in the initial email. I wonder whether it's a
>> problem with arcanist, or perhaps Daniel just didn't have a summary.
>
>
> "Feature" of arcanist :) It auto-detects the header somehow, so you need to
> get a line break in to get a summary...
>
> I'll look into the details to add it to the docs...
>
> Cheers,
> /Manuel