[cfe-dev] [cfe-commits] [PATCH] Implement has(), hasDescendant(), forEach() and forEachDescendant() for QualTypes and TypeLocs.

[David Blaikie]

On Fri, Oct 26, 2012 at 9:22 AM, Manuel Klimek <klimek at google.com> wrote:
> On Fri, Oct 26, 2012 at 6:17 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> Manuel, phab bug report: This didn't thread as a reply to the original
>> review mail in gmail.
>
>
> See
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121022/066885.html
>
> It did thread correctly. Note that Daniel changed the subject, and thus
> GMail cannot thread it correctly any more - pipermail's threading it shows
> that in theory the threading seems to be set correctly. To the best of my
> knowledge this is non-conforming behavior on GMail's side. (I might also be
> able to implement a "never change subject" switch in phab, if that's what
> we're after)

I believe that's the case (that GMail fails to respect the threading
headers). Some solution to this would be nice - either from gmail or
phab. But, yeah, I'm not sure if "you can't change the title" is a
limitation worth having for the gain of gmail threading...

- David

>
> Cheers,
> /Manuel
>
>>
>>
>> On Fri, Oct 26, 2012 at 5:13 AM, Daniel Jasper <djasper at google.com> wrote:
>> > Hi klimek,
>> >
>> > http://llvm-reviews.chandlerc.com/D83
>> >
>> > CHANGE SINCE LAST DIFF
>> >   http://llvm-reviews.chandlerc.com/D83?vs=211&id=212#toc
>> >
>> > Files:
>> >   include/clang/ASTMatchers/ASTMatchers.h
>> >   include/clang/ASTMatchers/ASTMatchersInternal.h
>> >   include/clang/ASTMatchers/ASTTypeTraits.h
>> >   lib/ASTMatchers/ASTMatchFinder.cpp
>> >   unittests/ASTMatchers/ASTMatchersTest.cpp
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> >
>
>