[cfe-dev] OpenCL & SPIR specific types - proposal and patch

[Benyei, Guy]

Attached a patch that makes sampler_t an i32 - I still think opaque types would be more in the OpenCL spec's spirit, however it's more important to get this patch committed. Changing the sampler_t representation won't be a big issue on top of this.

I've also added sampler_t initialization including restrictions, and fixed Anton Lokhmotov's latest remarks.

Please review.

Thanks


[email_signature_guy_new2]

From: Tanya Lattner [mailto:lattner at apple.com]
Sent: Monday, October 15, 2012 20:47
To: Benyei, Guy
Cc: Richard Smith; cfe-dev at cs.uiuc.edu; Villmow, Micah; Anton.Lokhmotov at arm.com
Subject: Re: [cfe-dev] OpenCL & SPIR specific types - proposal and patch

Given there is some discussion on sampler still, I suggest you remove it from your patch so the rest can get a final review and hopefully get into the tree.

-Tanya

On Oct 9, 2012, at 1:49 PM, "Benyei, Guy" <guy.benyei at intel.com<mailto:guy.benyei at intel.com>> wrote:


I've refactored the code to remove the repeated parts, and also fixed Anton Lokhmotov's comments.

Please review.

Thanks
<image001.png>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20121016/5eea9a2f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 24800 bytes
Desc: image001.png
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20121016/5eea9a2f/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opencl_types5.patch
Type: application/octet-stream
Size: 37767 bytes
Desc: opencl_types5.patch
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20121016/5eea9a2f/attachment.obj>
-------------- next part --------------
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20121016/5eea9a2f/attachment-0001.html>