[cfe-dev] Preprocessor/mmx.c and Preprocessor/predefined-arch-macros.c failed on MIPS

[Chandler Carruth]

On Wed, May 9, 2012 at 8:57 AM, Eli Friedman <eli.friedman at gmail.com> wrote:

> On Wed, May 9, 2012 at 4:30 AM, Simon Atanasyan <satanasyan at mips.com>
> wrote:
> > Separated from "[PATCH] Fix clang test failures on MIPS" thread.
> >
> > On Thu, May 3, 2012 at 4:29 AM, Eli Friedman <eli.friedman at gmail.com>
> wrote:
> >> On Wed, May 2, 2012 at 3:04 PM, Simon Atanasyan <satanasyan at mips.com>
> wrote:
> >>> Clang :: Preprocessor/mmx.c
> >>> Clang :: Preprocessor/predefined-arch-macros.c
> >>>
> >>> These test check definitions of various i386..x86-64 platforms specific
> >>> macros. I suggest to add "mips" to the XFAIL list for these tests.
> >>
> >> For those two tests, could you just force an appropriate triple with
> >> -ccc-host-triple?
> >
> > Yes, it is possible. The appropriate patch "tgt-force.patch" is
> > attached to this mail. But I'm not absolutely sure that this approach
> > is correct. If we pass a target triple explicitly, we check predefined
> > macros on that target only. If we do not pass a target triple, we
> > check predefined macros on each different target where we run the test
> > suite and we cover more cases.
> >
> > But if you do not see any problem here and "tgt-force.patch" is okay,
> > I will commit it.
>
> The benefit from the extra testing would be slight... better to just
> make it consistent.  Patch is fine.


Agreed.

Specifically, if we believe there might be differences from target to
target, we should add explicit runs with those triples so that developers
on other targets get the testing too...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120509/60c00c0d/attachment.html>