[cfe-dev] [PATCH] Fix clang test failures on MIPS

[Manuel Klimek]

On Thu, May 3, 2012 at 10:16 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Thu, May 3, 2012 at 12:59 PM, Simon Atanasyan <satanasyan at mips.com>
> wrote:
>>
>> On Thu, May 3, 2012 at 10:40 AM, Chandler Carruth <chandlerc at google.com>
>> wrote:
>> > On Wed, May 2, 2012 at 5:29 PM, Eli Friedman <eli.friedman at gmail.com>
>> > wrote:
>> >>
>> >> > Clang :: Tooling/clang-check.cpp
>> >> > Clang :: Tooling/clang-check-pwd.cpp
>> >> > Clang :: Tooling/clang-check-args.cpp
>> >> > Clang :: Tooling/clang-check-builtin-headers.cpp
>> >> >
>> >> > These tests expect that clang driver runs exactly one compiler job,
>> >> > but
>> >> > integrated assembler is turned off on MIPS by default and the driver
>> >> > runs
>> >> > two jobs. I suggest to add "mips" to the XFAIL list for these tests.
>> >>
>> >> Okay, but please add a comment noting why you're XFAILing it on MIPS.
>> >
>> >
>> > FWIW, I think this is a real bug that we should fix. Integrated
>> > assembler
>> > shouldn't impact these tools, there is probably something we're failing
>> > te
>> > set up correctly in the driver and invocation.
>> >
>> > I've CC-ed Manuel. We should be able to reproduce this by actively using
>> > the
>> > MIPS triple.
>>
>> Do you suggest to keep these test failed while the bug is not fixed?
>> It's not a problem - just want to clarify.
>>
>> By the way, if somebody give me a short intro to the tooling library
>> and "clang-check" tool, I would be happy to investigate the bug and
>> probably fix it.
>
>
> This was my hope, and why I CC'ed Manuel so he could provide some insight
> into why this might be failing....
>
> My understanding is that the tooling library wishes to only run a single
> compilation job, and is failing to properly set up the driver/invocation for
> that, leaving the external assembler job also in the pipeline. I'm not of
> the exact location of this code, but I think Manuel has seen related
> problems recently anyways.

Yep, we need to add a hook to adjust the compile command lines for
running a single syntax only job.
My idea was to add a hook that by default does that syntax only
modification and allow users to specify different hooks in case they
know what they're doing ...

Cheers,
/Manuel