[cfe-dev] Version agnostic path search for mingw

[Aaron Ballman]

On Tue, Mar 20, 2012 at 6:05 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote:
> Here's a patch that factors out the common code. Everything that had a
> version now calls AddVersionedCPlusPlusIncludes,
> AddGnuCPlusPlusIncludes is used for paths that don't mention version
> numbers, and C includes for mingw are specific enough to have their
> own function.
>
> The main issue that I see with this is that it's too specific. It just
> covers the cases that were already there. I would leave the generic
> solution to someone who knows the path issues better than me. If this
> is not the right approach I will go back to the previous patch and
> just submit the mingw fixes.

I think it's a good stab at generalization, but I see what you mean
about it not gaining very much.  I'd go back to the previous patch and
submit the mingw fixes.  I'm sorry that this causes you to throw away
work.  :-(

~Aaron