[cfe-dev] CompilationDatabase support added to libclang and python binding

[Arnaud de Grandmaison]

Hi Manuel & Gregory,

If there are no more feedback, can someone commit those patches for me ?
I do not have commit access.

Cheers,
--
Arnaud de Grandmaison

On 06/12/2012 09:28 AM, Arnaud de Grandmaison wrote:
> Hi Manuel and Gregory,
>
> Here are the patches for a second round of review. I took into account
> most of
> your suggestions, if not all.
>
> Here are the changes with respect to the previous set of patches.
>
> Regarding cindex:
>  - Index.h : declaration order changed to be more reader friendly
>  - CompilationDb moved to CompilationDatabase
>  - the clang_tooling_ prefix is kept for now, expressing this
> functionality comes
>    from a different module. We may want to move it into another header
> then Index.h
>    to even better express this. Which name should it have ? Tooling.h is
> already
>    in use. Beside the logical isolation, do we want a physical one, i.e.
> have a
>    separate library for tooling C interface ?
>  - the naming convention is now using consistently
> clang_tooling_<thing>_<action>
>  - i have not yet added the other available ways of loading a database.
> This can
>    probably be done later on, on demand
>  - i have not yet added higher level helpers like
>    clang_tooling_CompileCommand_getCmdLine. This should come latter,
> depending
>    on actual needs and uses.
>
> Regarding the python binding:
>  - space added after comma for the arguments of function calls
>  - method summary now on one line, when it is small enough to fit in 80
> columns.
>  - properties name have been changed to noun
>  - yield used instead of iterator for CompileCommand
>  - CompileCommands is no longer a hidden object.
>  - CompilationDb moved to CompilationDatabase
>  - from_result method used for checking CompilationDatabase &
> CompileCommands
>  - test_cdb.py : comparisons are now done using lists
>
>
> Cheers,
>


-- 
Arnaud de Grandmaison