[cfe-dev] [libc++] r160604 appears to have broken libc++ on linux

[Andrew C. Morrow]

>>>
>>> Ok, I'm testing a solution that looks like this:
>>>
>>> Index: include/__locale
>>> ===================================================================
>>> --- include/__locale    (revision 160055)
>>> +++ include/__locale    (working copy)
>>> @@ -119,7 +119,7 @@
>>>
>>>      static int32_t __next_id;
>>>  public:
>>> -    _LIBCPP_INLINE_VISIBILITY id() {}
>>> +    _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR id() :__id_(0) {}
>>>  private:
>>>      void __init();
>>>      void operator=(const id&); // = delete;
>>>
>>> Could you test that out as well?  My hope is that this will force the id() constructor to be constructed at compile time.
>>>
>>> Thanks,
>>> Howard
>>>
>>
>> I just tried it out and my little test passes now. So this looks very
>> promising! I will try getting the libc++abi and libc++ unit tests
>> going next.
>>
>> Thanks,
>> Andrew

Hi Howard -

Sorry for the delay getting to the tests.

After applying your patch all of the libc++abi tests and the majority
of the libc++ tests are passing again. The small set of failing libc++
tests is consistent with pre-r160604 behavior.

Thanks,
Andrew