[cfe-dev] New warning for mismatched include case

[Ted Kremenek]

Hi Jason,

Any idea what is the performance impact of this change?  My concern that this is potentially expensive, and we shouldn't be performing the check on a case-sensitve file system (if we can help it).  That said, many people have requested this kind of checking, so I'm happy to see you taking a stab at it.

Ted	

On Jul 18, 2012, at 3:09 PM, Jason Haslam <jason.haslam at gmail.com> wrote:

> The attached (incomplete proof-of-concept) patch provides a new warning that fires on case-insensitive file systems when the case of the file name in the #include directive doesn't match the case of the file name on disk. The idea is to avoid broken commits that fail to build on case-sensitive file systems. For example:
> 
> jason$ ls
> test.cpp test.h
> jason$ cat test.cpp
> #include "Test.h"
> jason$ clang++ -fsyntax-only test.cpp 
> test.cpp:1:10: warning: include case does not match the case of the file on disk
> #include "Test.h"
>         ^
> 1 warning generated.
> 
> What do you think? Is this desirable? Does the direction look right?
> 
> Jason
> 
> <include_case.diff>_______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev