[cfe-dev] [PATCH] Fixit for incorrect includes

[Aaron Ballman]

This patch includes suggestions from David and Sebastian in terms of
functionality and wording.

~Aaron

On Tue, Jul 17, 2012 at 2:46 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Tue, Jul 17, 2012 at 2:37 PM, Sebastian Redl
> <sebastian.redl at getdesigned.at> wrote:
>>
>> On 17.07.2012, at 20:52, David Blaikie wrote:
>>
>> On Tue, Jul 17, 2012 at 11:46 AM, Aaron Ballman <aaron at aaronballman.com>
>> wrote:
>>
>> Do we want to have a fatal and non-fatal
>>
>> variant of the error (fatal for when no fixit is available)?
>>
>>
>> Yes, I believe that'd be necessary. They can have different diagnostic
>> names but the same text and just one of them is non-fatal.
>>
>>
>> The non-fixit and fixit diagnostics would probably have different text
>> anyway. "Header not found" and "Header not found as written, but found if
>> looked up as if it was written with quotes" are pretty different.
>
> Would it be fine to use "file not found as written"?  I ask because I
> can see a second fixit coming pertaining to spelling or case
> sensitivity.
>
> ~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: include_fixit.patch
Type: application/octet-stream
Size: 2990 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120717/f56c1843/attachment.obj>