[cfe-dev] [PATCH] get access to all files of compilation database

[Manuel Klimek]

On Fri, Jul 13, 2012 at 9:37 AM, Tobias Koenig <tobias.koenig at kdab.com> wrote:
> On Friday 13 July 2012 08:56:01 Manuel Klimek wrote:
>> > Any suggestions, objections, comments?
> Hej Manuel,
>
>> LGTM
>>
>> apart from "." missing at the end of the \brief comments :)
>>
>> Do you have commit access?
> Unfortunately not, can you or somebody else commit it for me, please?
> (including the missing "." ;)).
>
> Please not that the patch has been created against the tooling branch and not
> trunk.

One more thing I notice is missing: a unit test for the
JSONCompilationDatabase::getAllFiles :)
If you need help where to put that, let me know ...

Cheers,
/Manuel

>
> Ciao,
> Tobias
> --
> Tobias Koenig | tobias.koenig at kdab.com | Developer
> KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
> Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
> KDAB - Qt Experts - Platform-independent software solutions