[cfe-dev] [PATCH] __interface support (with isVirtual fix)
David Robins
llvm at davidrobins.net
Sun Aug 26 14:46:14 PDT 2012
I think the name works as-is - an interface is a class/structure type
(of the family).
I'll send it on to cfe-commits - I didn't know that was for uncommited
patches too.
On Sun, Aug 26, 2012 at 06:53:28PM +0100, João Matos wrote:
> Looks good to me.
> Minor nitpick:
> bool Type::isStructureOrClassType() const;
> Should we rename this since now it also checks for interfaces?
> By the way, patch submissions should be sent to cfe-commits instead.
> On Sun, Aug 26, 2012 at 2:47 AM, David Robins <llvm at davidrobins.net>
> wrote:
>
> Updated patch attached; patch also updated to be against current
> revision (162644 at time of writing). All tests pass.
>
> It removes the call to setVirtualAsWritten and instead, as suggested by
> John McCall, modifies CXXMethodDecl::isVirtual to return true if either
> virtual as written is set or the method is declared in an interface.
>
> (As I noted before, I do not have commit access so if approved I will
> need someone else to commit this change.)
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
> --
> Joao Matos
More information about the cfe-dev
mailing list