[cfe-dev] Expect new Phabricator code review test runs

[Thiago Farina]

On Sun, Aug 19, 2012 at 8:29 AM, Konstantin Tokarev <annulen at yandex.ru> wrote:
>
>
> 19.08.2012, 12:05, "Manuel Klimek" <klimek at google.com>:
>> On Sat, Aug 18, 2012 at 11:19 PM, Thiago Farina <tfransosi at gmail.com> wrote:
>>
>>>  On Thu, Aug 16, 2012 at 9:35 AM, Manuel Klimek <klimek at google.com> wrote:
>>>>  On Thu, Aug 16, 2012 at 2:14 PM, Konstantin Tokarev <annulen at yandex.ru> wrote:
>>>>>  16.08.2012, 11:30, "Manuel Klimek" <klimek at google.com>:
>>>>>>  Hi,
>>>>>>
>>>>>>  last month we tried Phabricator for code reviews and got some great
>>>>>>  feedback on what's missing. The main issue was that email
>>>>>>  notifications were really bad. We've worked on that, and would like to
>>>>>>  run some more tests by using it and gather some more feedback from the
>>>>>>  community.
>>>>>  I'm a bit surprised that you being @google.com don't promote Gerrit [1].
>>>>  We want to use what fits the project best. Gerrit is a great tool for
>>>>  a lot of use cases, unfortunately it doesn't fit the clang/llvm
>>>>  workflow well. Of course I looked into Gerrit / Rietveld etc, but all
>>>>  of them have serious downsides
>>>  Could you develop on those downsides?
>>
>> Yes. There are two questions though: what's the effort, and would
>> upstream gerrit accept patches that for example enable a post-review
>> subversion browser for post-commit reviews (I use phab to browse
>> revisions now because it's better than the websvn stuff).
>
> Not sure about Rietveld, but in Gerrit every change which went through review
> system could be reviewed post-commit as well.
>
you can still browse reviews that were already committed without any
problems in rietveld/codeview.