[cfe-dev] [PATCH] Libc++ Windows fixes (Attention all libc++ ports!!!)

[Howard Hinnant]

On Sep 28, 2011, at 11:02 AM, Ruben Van Boxem wrote:

> If this is just replacing all occurences  of the __*_l functions in libc++ code with the normal *_l functions, and removing all the always inline wrappers, I can volunteer to do this mechanical work. I guess the only port directly affected by this would be Linux, but that could easily be fixed by introducing a support header and moving the wrapper code from <locale> to there.

Perhaps the best way to proceed is for someone such as yourself to just untangle the Windows port from this block of code:

// OSX has nice foo_l() functions that let you turn off use of the global
// locale.  Linux, not so much.  The following functions avoid the locale when
// that's possible and otherwise do the wrong thing.  FIXME.
#ifndef _LIBCPP_STABLE_APPLE_ABI

Someone else (perhaps David) could just untangle the FreeBSD port from the same block of code.

Perhaps someone else can untangle the Linux port from this block of code.

Once everybody is untangled from it, we can safely delete it because no one will be using it.  But I hesitate to have anyone work this area without the ability to test it for the impacted platform.

Howard