[cfe-dev] [PATCH] MS compatibility flag implies delayed parsing

Aaron Ballman aaron at aaronballman.com
Tue Nov 15 10:50:58 PST 2011


On Tue, Nov 15, 2011 at 11:49 AM, David Blaikie <dblaikie at gmail.com> wrote:
> On Tue, Nov 15, 2011 at 7:49 AM, Francois Pichet <pichet2000 at gmail.com> wrote:
>> On Mon, Nov 14, 2011 at 8:46 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>>> On Mon, Nov 14, 2011 at 5:53 PM, Francois Pichet <pichet2000 at gmail.com> wrote:
>>>> This doesn't work.
>>>> Some tests depend on -fno-delayed-template-parsing to exist at the driver level.
>>>
>>> Good catch!  I've revised the patch so that
>>> -fno-delayed-template-parsing will be honored in the driver.
>>
>> Having option -fno-delayed-template-parsing without
>> -fdelayed-template-parsing doesn't sound right to me.
>> How about we keep it.

Are you suggesting we keep the flag, but still make it implicitly on
when ms-compatibility is specified?  Or just keep things as they are
today?  I am fine with keeping the flag, but I still think we should
implicitly turn it on for ms-compatibility.

> Shouldn't those tests that are currently using
> -fno-delayed-template-parsing be modified to use -fms-compatibility or
> pass -fno-delayed-template-parsing via -Xclang? Or are those test case
> enough to justify the existence of -fno-delayed-template-parsing as a
> driver-visible flag?

I usually figure that if there's a test for it, there's a reason for
it, so I think they do justify the ability to turn off delayed
template parsing explicitly.

~Aaron




More information about the cfe-dev mailing list