[cfe-dev] [OpenCL patch] asType, Convert **revised**

Tanya Lattner lattner at apple.com
Wed May 25 15:35:09 PDT 2011


Here is the revised patch w/ Eli's suggestions.




Thanks,
Tanya

On May 25, 2011, at 3:08 PM, Tanya Lattner wrote:

> The attached patch adds support for builtins for astype, convert, and vec_step. I chose to group these together because they require very similar code modifications. I've included test cases for each.
> 
> __builtin_astype(): Used to reinterpreted as another data type of the same size using for both scalar and vector data types.
> __builtin_convert(): provides a way to perform scalar and vector conversions with rounding and saturation.
> 
> I have fixed the concerns with asType and other areas as mentioned by Guy Benyei in his review. 
> 
> If there is no further objection and because this patch has had extensive review and has been out there for a long time, I feel this is ready to be committed and plan to do so shortly.
> 
> Thanks,
> Tanya
> 
> <asTypeConvertExpr.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110525/b1a13e24/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asTypeConvertExpr-2.patch
Type: application/octet-stream
Size: 28982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110525/b1a13e24/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110525/b1a13e24/attachment-0001.html>


More information about the cfe-dev mailing list