[cfe-dev] -fdiagnostics-format= design review : added enum to patch

[Andrew Fish]

>> On May 18, 2011, at 12:38 PM, Andrew Fish wrote:
>> 
>>> Doug,
>>> 
>>> Thanks for the help on this. Please review:
>>> 
>>> -fdiagnostics-format=none/clang/msvc/vi: Changes diagnostic output format to better match IDEs and command line tools.
>>> This option, which defaults to "none", controls the output format of the filename, line number, and column printed in diagnostic messages. 
> 
> Why is there a value "none"?
> 

Looks like I missed my last sentence:

The value none means pick a default that best matches the triple being used. Maybe default would be a better name for this?

I'm good with making the default clang, but I was trying to keep the current behavior of the defaults for a Windows ABI flavor of ABI being msvc.  

Good catch,

Andrew 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110518/c6f0569d/attachment.html>