[cfe-dev] Status of constexpr

Sean Hunt scshunt at csclub.uwaterloo.ca
Wed May 11 13:26:04 PDT 2011


On 05/11/11 13:19, Peter Collingbourne wrote:
> Try r128978 of LLVM, that was the latest version of clang that I
> merged from.

Ok, thanks.

>> You also have
>> include/clang/AST/StmtVisitor.inc in the repository, which is a no-no.
>
> StmtVisitor.inc isn't a generated file, if that's what you're thinking.
> StmtVisitor.inc contains the common implementation of StmtVisitor and
> ConstStmtVisitor which I #include twice to define those two classes.
> I guess the other way to do it would be to use a base class with
> a template template parameter (e.g. below) which may be slightly
> less ugly.

Ah, ok. You should probably pick a different name; .inc breaks the CMake 
build as CMake thinks that it's a generated file.

> That is just a git merge from SVN trunk every so often.  Perhaps gitk
> will show the commit graph more clearly.

> Well, it works for me in practice.  I just commit and merge when
> necessary.  If I wanted to commit something from that branch to SVN
> trunk then I use git cherry-pick and rebase if necessary.  This method
> saves me from having to mess around with rewriting history until I
> commit to trunk.
>
> Thanks,

I suppose.

Sean



More information about the cfe-dev mailing list