[cfe-dev] [LLVMdev] Language-specific vs target-specific address spaces (was Re: [PATCH] OpenCL support - update on keywords)

[Ken Dyck]

On Fri, Mar 11, 2011 at 4:59 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> I have completed my patch (attached) based on my suggestions here
> and the subsequent discussion.

Could the language-specific address space numbers be translated to
target-specific ones when the keywords are parsed in
Parser::ParseOpenCLAttributes()? Then the Qualifier would be
guaranteed to contain a target-specific address space and there
wouldn't really be any need for ASTContext::getTargetAddressSpace().
I'm a bit concerned that having two ways to get the address space of a
pointer type, each potentially giving different results, will cause
confusion and errors in the future.

-Ken