[cfe-dev] clang bootstrap broken on darwin10

[Eric Christopher]

On Mar 6, 2011, at 5:53 PM, Jack Howarth wrote:

> Chris,
>   The following patch eliminates the build problems for llvm svn
> when llvm 2.8 is installed...
> 
> Index: Makefile.rules
> ===================================================================
> --- Makefile.rules	(revision 127128)
> +++ Makefile.rules	(working copy)
> @@ -655,8 +655,8 @@ ifeq ($(BUILD_COMPONENT), 1)
>   Preprocess.CXX= $(BUILD_CXX) $(CPP.Flags) $(CPPFLAGS) $(TargetCommonOpts) \
>                   $(CompileCommonOpts) $(CXX.Flags) -E
>   Link          = $(BUILD_CXX) $(CPP.Flags) $(CXX.Flags) $(CXXFLAGS) \
> -		  $(LDFLAGS) \
> -                  $(TargetCommonOpts) $(CompileCommonOpts) $(LD.Flags) $(Strip)
> +		  $(LD.Flags) $(LDFLAGS) \
> +                  $(TargetCommonOpts) $(CompileCommonOpts) $(Strip)
> else
>   Compile.C     = $(CC) $(CPP.Flags) $(C.Flags) $(CFLAGS) $(CPPFLAGS) \
>                   $(TargetCommonOpts) $(CompileCommonOpts) -c
> @@ -664,8 +664,8 @@ else
>                   $(TargetCommonOpts) $(CompileCommonOpts) -c
>   Preprocess.CXX= $(CXX) $(CPP.Flags) $(TargetCommonOpts) $(CPPFLAGS) \
>                   $(CompileCommonOpts) $(CXX.Flags) -E
> -  Link          = $(CXX) $(CPP.Flags) $(CXX.Flags) $(CXXFLAGS) $(LDFLAGS) \
> -                  $(TargetCommonOpts)  $(CompileCommonOpts) $(LD.Flags) $(Strip)
> +  Link          = $(CXX) $(CPP.Flags) $(CXX.Flags) $(CXXFLAGS) $(LD.Flags) \
> +                  $(LDFLAGS) $(TargetCommonOpts)  $(CompileCommonOpts) $(Strip)
> endif
> 
> BCCompile.C   = $(LLVMCC) $(CPP.Flags) $(C.Flags) $(CFLAGS) $(CPPFLAGS) \
> 
> Note that currently care is being taken that C.Flags appears before CFLAGS or
> CPPFLAGS. The same level of attention needs to be taken to insure that LD.Flags
> appears before LDFLAGS in Makefile.rules. Can we get this fix into svn?
>  

Yeah. That seems reasonable.

Can you resend your patch to me as an attachment?

Thanks!

-eric