[cfe-dev] Interest in a -Wimplicit-virtual?

[Douglas Gregor]

On Mar 2, 2011, at 2:07 PM, Ted Kremenek wrote:

> I'd be fine with this being an optional warning, but not on by default.

+1

> On Mar 2, 2011, at 2:01 PM, Elliot Glaysher (Chromium) wrote:
> 
>> In the chromium clang plugin, we check for the following case:
>> 
>> struct A {
>> virtual void method();
>> };
>> 
>> struct B : public A {
>> void method(); // expected-warning {{Overridden method must have
>> "virtual" keyword}}
>> };
>> 
>> Our style guide requires people to not depend on virtual being
>> implicit. Would there be interest in upstreaming this warning to the
>> cfe proper?
>> 
>> -- Elliot Glaysher
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> 
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev