[cfe-dev] [libc++][patch] Improving Linux support

[Petteri Räty]

On 13.6.2011 18.12, Howard Hinnant wrote:
> 
> Sorry for the delay in reviewing this.
> 
> Comments:
> 
> I'm not comfortable with moving the __APPLE__ code away from the *_l
> functions.  I appreciate that the functionality has been replicated
> within the with_locale function.  But I am nervous about the
> performance implications of reinventing the *_l for __APPLE__.
> 

Do you have numbers on how much the difference is or what the
implications could be?

>
> On the positive side, you've achieved good code reuse with
> with_locale.  Perhaps it would be good to reinvent the *_l functions
> using with_locale *only* for those platforms which don't already have
> *_l and do have the per-thread uselocale.
> 

As the documented build script is just a simple shell script what
approach do you suggest for the detection? Just assume only POSIX and
only activate *_l if explicitly requested with for example __APPLE__?

Regards,
Petteri