[cfe-dev] [PATCH] C++0x unicode string and character literals now with test cases

Sean Hunt scshunt at csclub.uwaterloo.ca
Mon Jul 25 12:14:40 PDT 2011


On Mon, Jul 25, 2011 at 11:44, Douglas Gregor <dgregor at apple.com> wrote:
> Also, please remove the 'default' case; it's enough that the switch statement is exhaustive.

What if the value is outside the range of enumerators? This could
certainly happen due to, say, a PCH bug. I would point out that we
prefer llvm_unreachable for impossible cases though. In either case,
there ought to be no real cost since this will all get elided in
release mode.

Sean



More information about the cfe-dev mailing list