[cfe-dev] OpenCL patch: vector literals (alternative patch)

Tanya Lattner lattner at apple.com
Wed Jul 13 11:43:58 PDT 2011


I'll commit what I have, and when you get more time next week, you can re-evaluate if the additional work is needed.  This obviously doesn't have to be the final patch if there are indeed outstanding issues. Hopefully thats sounds fair to you.


On Jul 13, 2011, at 11:40 AM, Anton Lokhmotov wrote:

> Hi Tanya,
>> You shouldn't need to add anything from your patch to mine to get the
>> test cases to work. Why do you think this extra code is necessary? Do
>> you have a test case that isn't in the invalid/valid files that fails?
> I'm a bit surprised this test passes without our modifications:
>> ((float4)(1.0f))++; // expected-error{{expression is not assignable}}
> Also, I was in a hurry and didn't include invalid tests for explicit and
> implicit conversions between vector types, e.g.
> uint4 u = (uint4)(1);
> int4 i = u; // invalid implicit conversion
> int4 e = (int4)u; // invalid explicit conversion
> Best regards,
> Anton.
> P.S. I won't be able to reply until early next week - apologies in advance.

More information about the cfe-dev mailing list