[cfe-dev] [patch] Support for C++0x raw string literals

Chris Lattner clattner at apple.com
Wed Aug 10 09:27:20 PDT 2011


It is really a coding standards sort of thing, we prefer stringref for string slices.

-Chris

On Aug 10, 2011, at 12:29 AM, Craig Topper <craig.topper at gmail.com> wrote:

>> +++ include/clang/Lex/LiteralSupport.h  (working copy)
>> @@ -197,6 +197,7 @@
>> 
>>  private:
>>   void init(const Token *StringToks, unsigned NumStringToks);
>> +  void CopyStringFragment(const char *Start, const char *End);
>> 
>> 
>> This should probably take a StringRef.
> 
> Given the low level nature of the code inside that method does
> changing it to a StringRef really accomplish much?
> 
> -- 
> ~Craig



More information about the cfe-dev mailing list